Membership Block #9802

artpi · 2018-06-19T16:14:42Z

This is the first PR of the block that is intended to provide something that beta users can test. We intend to work in small iterations and we will gladly address feedback in later PRs.

This introduces membership-button block to Jetpack.
This essentially will be a recurring donation button.

Purpose of the code in this PR is to:

introduce endpoints that communicate with WPCOM
whitelist certain options, CPTs and meta to store / sync data,
introduce gutenberg block that uses these endpoints and provides UI to connect to Stripe, create and choose a product
introduce a frontend of a block with the sole purpose of displaying a checkout window from wpcom in an iframe

~~This needs D26086-code .~~ - deployed

Screenshots

Internal references:

p89M8K-4a-p2
p1HpG7-6n6-p2

Testing instructions - Jurassic Ninja

The problem with this is that you can only use real money and real stripe accounts. If you want sandbox payments, you need to use the ngrok flow

https://jurassic.ninja/create/?jetpack-beta&branch=add/memberships
Connect Jetpack, enable "BETA_BLOCKS" in /wp-admin/options-general.php?page=companion_settings
Go to editor
Search for "Membership button" block
You will get a placeholder that will say "connect to stripe", click that
If you correctly set up the store sandbox, you will get "you can skip this form" at the top, click that
You will get redirected to ugly looking page on success
Now go back to gutenberg, click "Re-check Connection", wait
Now you should have a button to add product, click it, fill the form
choose your new product
Publish the page
12 Go to frontend, click the button that says contribution
go with the flow

Testing instructions - Jetpack Docker

Set up Jetpack with docker and ngrok.io, connnect jetpack
Remember to turn on beta blocks

define( 'GUTENBERG_DEVELOPMENT_MODE', true );
define( 'JETPACK_BETA_BLOCKS', true );

Checkout this PR
Build blocks by

yarn build-extensions

Continue from point 3. in the previous instruction

oskosk · 2018-06-28T16:27:39Z

@artpi there are a few JS linting messages on the test runs:

modules/memberships/memberships.js
  line 23  col 76  Strings must use singlequote.
  line 24  col 40  Strings must use singlequote.
  line 25  col 97  Strings must use singlequote.
  line 26  col 60  Strings must use singlequote.
  line 26  col 86  Strings must use singlequote.
  line 27  col 29  Strings must use singlequote.
  line 11  col 13  'console' is not defined.
  line 16  col 13  'tb_remove' is not defined.
  line 30  col 13  'tb_show' is not defined.

jetpackbot · 2019-03-27T21:58:37Z

	Warnings
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against a2c7318

jeherve

Just a few minor comments, I have not had the time to fully test this yet.

Also, and since we are introducing a bunch a new files, what do you think about adding them all to the pre-commit hook here in Jetpack?

jetpack/bin/pre-commit-hook.js

Line 37 in 7b6c749

'class.jetpack-plan.php',

We've been trying to do that for all new files to slowly move towards better code coverage in the plugin.

_inc/lib/core-api/wpcom-endpoints/memberships.php

extensions/blocks/membership-button/index.js

modules/memberships/class-jetpack-memberships.php

modules/module-extras.php

_inc/lib/core-api/wpcom-endpoints/memberships.php

blockers have been fixed

jeherve

Let's merge this now and address the feedback in future PRs.

It's worth noting that I'm currently having issues inserting new amounts. I get the following JavaScript error when I try to submit a new amount:

Uncaught (in promise) TypeError: Cannot read property 'id' of null
    at eval (edit.jsx:194)

This matches the following error on WordPress.com:

Fatal error: Uncaught Error: Call to undefined method WP_Error::to_array() in [...]jetpack-endpoints/memberships.php:105

kraftbj · 2019-04-29T22:04:01Z

Merged, but let's definitely address the API this week (Crew) and this new error asap (@artpi).

BurlesonBrad · 2019-05-09T21:08:37Z

I'm not wanting to go down the coding rabbit hole any more, but here's an innertubes show for ya to see and watch what happens:
http://youtu.be/SNxLOaHWAt8?hd=1

First, It says I'm NOT connected to the Pack-O-Jets. Which, I am!! I've paid for the Premium Jets:

After the "You ain't connected to the Packs de La Jets" prompt, the "Connect to Stripe" button can't be clicked at all.

Great, first it prompts me that my Packs don't get to connect with any Jets. And now they don't get to have any Stripes either. Awesomesauce. 😭

I turned on my Beta Blockers and loaded up the Gutenberries as well 👍

Well. That didn't help either 😢

So, I decided to retry the Stripes, the Memberships, The Guttenberries, and the PacksOfJets again at 00:36 & still nothing https://youtu.be/SNxLOaHWAt8?t=36

jeherve · 2019-05-10T07:21:21Z

@BurlesonBrad That error message should be displayed when the user you are logged in with is not linked to any WordPress.com account.

When you originally connected your site to WordPress.com, you did so while logged in as an admin on your site. If another admin wants to use the Memberships block, they'll need to link their own account to WordPress.com first. Does that make sense, and apply to you here, or do you see that error message while logged in with the admin account you used when you first connected your site to WordPress.com?

If the error appears even though the account you are currently logged in with is linked to WordPress.com, could you contact us via this form so we can run more tests with you and get this fixed?

Thank you!

BurlesonBrad · 2019-05-10T13:06:34Z

Yessir. In that quick vid and the screenshot as well, both are logged in and connected to the same WP.com account that I've had since dinosaurs roamed the planet.

artpi added the [Status] In Progress label Jun 19, 2018

artpi requested a review from a team as a code owner June 19, 2018 16:14

brbrr added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jun 20, 2018

stale bot added the [Status] Stale label Sep 27, 2018

jeherve added the [Block] Payment Button aka Recurring Payments label Sep 27, 2018

stale bot removed the [Status] Stale label Sep 27, 2018

stale bot added the [Status] Stale label Dec 27, 2018

artpi removed the [Status] Stale label Dec 28, 2018

artpi force-pushed the add/memberships branch from 34c1073 to 2836273 Compare March 25, 2019 12:43

artpi requested a review from a team March 25, 2019 12:43

artpi force-pushed the add/memberships branch from 2836273 to a72a7c4 Compare March 27, 2019 15:42

artpi requested review from rralian, eoigal, prettyboymp, davemart-in, nbloomf, kanishkdudeja and DavidRothstein March 27, 2019 17:27

Automattic deleted a comment from stale bot Mar 27, 2019

Automattic deleted a comment from jetpackbot Mar 27, 2019

jeherve requested changes Mar 28, 2019

View reviewed changes

jeherve requested a review from a team March 28, 2019 11:10

jeherve assigned artpi Mar 28, 2019

jeherve reviewed Mar 28, 2019

View reviewed changes

_inc/lib/core-api/wpcom-endpoints/memberships.php Outdated Show resolved Hide resolved

artpi added 7 commits April 29, 2019 23:41

Review feedback: remove unnecessary import

a7761d6

Better feedback where my account is not connected

4235ae9

Endpoints nly for wpcom/active jetpack

9bae01c

remove unused function

4c3153d

Additional check if JP is active

fea7f0b

Pass Lang to subscribe form

81c6d9c

error catching

7956f6a

jeherve force-pushed the add/memberships branch from 3f8aa11 to 7956f6a Compare April 29, 2019 21:42

PHPCS whitelist: add the whole new module folder to the pre-commit

6a57671

jeherve approved these changes Apr 29, 2019

View reviewed changes

kraftbj merged commit e9589a3 into master Apr 29, 2019

matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 29, 2019

kraftbj deleted the add/memberships branch April 29, 2019 22:04

kraftbj added [Status] Has Changelog and removed [Status] Needs Changelog labels Apr 30, 2019

kraftbj added a commit that referenced this pull request Apr 30, 2019

CL: #9802

9bec2b1

artpi mentioned this pull request May 1, 2019

Memberships: Product creation fail message #12226

Merged

kraftbj mentioned this pull request May 2, 2019

Remove JP Constants Automattic/companion#24

Merged

This was referenced May 20, 2019

Memberships: fix button presentation #12416

Merged

Memberships: flip to production #12455

Merged

artpi mentioned this pull request May 29, 2019

Memberships: Rename to "Recurring Payments" #12488

Merged

artpi mentioned this pull request Jun 13, 2019

Recurring Payments: Widget #12684

Closed

artpi mentioned this pull request Sep 3, 2019

Recurring Payments: change alignment #13310

Merged

artpi mentioned this pull request Oct 9, 2019

Recurring Payments: better wording around "plan" #13697

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Membership Block #9802

Membership Block #9802

artpi commented Jun 19, 2018 •

edited

Loading

oskosk commented Jun 28, 2018

jetpackbot commented Mar 27, 2019 •

edited

Loading

jeherve left a comment

jeherve left a comment

kraftbj commented Apr 29, 2019

BurlesonBrad commented May 9, 2019

jeherve commented May 10, 2019

BurlesonBrad commented May 10, 2019

Membership Block #9802

Membership Block #9802

Conversation

artpi commented Jun 19, 2018 • edited Loading

This is the first PR of the block that is intended to provide something that beta users can test. We intend to work in small iterations and we will gladly address feedback in later PRs.

Screenshots

Internal references:

Testing instructions - Jurassic Ninja

Testing instructions - Jetpack Docker

oskosk commented Jun 28, 2018

jetpackbot commented Mar 27, 2019 • edited Loading

jeherve left a comment

Choose a reason for hiding this comment

jeherve left a comment

Choose a reason for hiding this comment

kraftbj commented Apr 29, 2019

BurlesonBrad commented May 9, 2019

jeherve commented May 10, 2019

BurlesonBrad commented May 10, 2019

artpi commented Jun 19, 2018 •

edited

Loading

jetpackbot commented Mar 27, 2019 •

edited

Loading